Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of RTC and regulator module #41

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Conversation

dr-stefan-krank
Copy link
Collaborator

Rework of regulator and RTC.
Open for review.

Moved power cutoff to the regulator module.
Added labels for INT and GPIO EN Pins to the master sheet.
@wassfila
Copy link
Collaborator

looks good to me, but can you maybe specify roughly what the rework was ?

@dr-stefan-krank
Copy link
Collaborator Author

Moved the cut-off mosfet to the regulator module and instead just routed the INT from the RTC to it.
Added EN connections for the additional regulators to the MCU board, so they can be switched with GPIOs.
Didn't add the hierarchical labels on the MCU sheet itself, to prevent conflicts with the MCU branch.

@wassfila
Copy link
Collaborator

wassfila commented Oct 25, 2020

Yeah @dr-stefan-krank well done, regarding the MCU sheet maybe you can help in #36 as @2010019970909 is a bit busy with studies these times. I don't think we have to redo anything in there just fixing the DRC and merging at a first step, we can discuss it Today.

@wassfila wassfila mentioned this pull request Oct 25, 2020
@Vincent-Stragier
Copy link
Collaborator

Yep, any help is welcome.
I've tried to track the changes that have still to be done here.

For the DRC, on the MCU sheet, there is only one relative to the MCU (one pin of the pins header not connected, which is related to the replication of the low cost version which I did not do yet). The rest of the DRC errors is on other sheets. Also there was two remarks on #39 (one about using net label (I suppose for the voltages, etc., but they are global one in KiCad, so we have to be in sync).

@wassfila wassfila mentioned this pull request Oct 25, 2020
@wassfila
Copy link
Collaborator

Yep, any help is welcome.
I've tried to track the changes that have still to be done here.

For the DRC, on the MCU sheet, there is only one relative to the MCU (one pin of the pins header not connected, which is related to the replication of the low cost version which I did not do yet). The rest of the DRC errors is on other sheets. Also there was two remarks on #39 (one about using net label (I suppose for the voltages, etc., but they are global one in KiCad, so we have to be in sync).

ok, I shifted these comments on #43 and we'll mix them with the TODO from the project

@wassfila
Copy link
Collaborator

Team review

  • to check the pull up again before merge
  • to add pull up on RTC sheet or on the regulators sheet
  • cutoff enable in stead of VIN possible

@dr-stefan-krank dr-stefan-krank marked this pull request as ready for review October 26, 2020 20:29
Copy link
Collaborator

@wassfila wassfila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, I checked everything opens without issues, interactions required with the mcu sheet so better go through the master.
If any findings are noticed after this merge they should simply be documented on a ticket.

@wassfila wassfila merged commit 8071118 into master Oct 27, 2020
@wassfila wassfila deleted the feature/regulator_rtc branch October 27, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants