-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of RTC and regulator module #41
Conversation
Moved power cutoff to the regulator module. Added labels for INT and GPIO EN Pins to the master sheet.
looks good to me, but can you maybe specify roughly what the rework was ? |
Moved the cut-off mosfet to the regulator module and instead just routed the INT from the RTC to it. |
Yeah @dr-stefan-krank well done, regarding the MCU sheet maybe you can help in #36 as @2010019970909 is a bit busy with studies these times. I don't think we have to redo anything in there just fixing the DRC and merging at a first step, we can discuss it Today. |
Yep, any help is welcome. For the DRC, on the MCU sheet, there is only one relative to the MCU (one pin of the pins header not connected, which is related to the replication of the low cost version which I did not do yet). The rest of the DRC errors is on other sheets. Also there was two remarks on #39 (one about using net label (I suppose for the voltages, etc., but they are global one in KiCad, so we have to be in sync). |
ok, I shifted these comments on #43 and we'll mix them with the TODO from the project |
Team review
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, I checked everything opens without issues, interactions required with the mcu sheet so better go through the master.
If any findings are noticed after this merge they should simply be documented on a ticket.
Rework of regulator and RTC.
Open for review.