feat: gcp app connections and secret sync #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
confused deputy |
|
add docs for enabling required APIs |
scott-ray-wilson
requested changes
Jan 27, 2025
...SettingsPage/components/AppConnectionsTab/components/AppConnectionForm/GcpConnectionForm.tsx
Show resolved
Hide resolved
frontend/src/components/secret-syncs/forms/SecretSyncReviewFields/GcpSyncReviewFIelds.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/secret-syncs/forms/SecretSyncReviewFields/GcpSyncReviewFIelds.tsx
Outdated
Show resolved
Hide resolved
...components/SecretSyncsTab/SecretSyncTable/SecretSyncDestinationCol/GcpSyncDestinationCol.tsx
Show resolved
Hide resolved
scott-ray-wilson
requested changes
Jan 27, 2025
frontend/src/components/secret-syncs/forms/SecretSyncDestinationFields/GcpSyncFields.tsx
Outdated
Show resolved
Hide resolved
scott-ray-wilson
approved these changes
Jan 28, 2025
frontend/src/components/secret-syncs/forms/SecretSyncDestinationFields/GcpSyncFields.tsx
Show resolved
Hide resolved
...SettingsPage/components/AppConnectionsTab/components/AppConnectionForm/GcpConnectionForm.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR adds support for GCP app connection
It also adds support for GCP secret manager syncs.
Along with these new additions are the appropriate docs
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets