misc: addressed invalid redirect condition in signup invite page #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielHougaard
requested review from
DanielHougaard
and removed request for
akhilmhdh
|
Looks good to me. It doesn't make sense that an invited user should get this far and not be able to sign up without global sign up being set. |
DanielHougaard
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR resolves the following issue: #2446
Basically it removes a condition in the signupinvite page that blocked invited users from creating an account when instance allow signup option is set to "Disabled"
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets