test: remove unnecessary default branch property

InditexTech · May 13, 2024 · b95513a · b95513a
1 parent fd9c2c4
commit b95513a
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/internal/use_cases/create_pull_request_test.go b/internal/use_cases/create_pull_request_test.go
@@ -17,7 +17,6 @@ import (
 
 type CreatePullRequestExecutionTestSuite struct {
 	suite.Suite
-	defaultBranchName       string
 	uc                      use_cases.CreatePullRequest
 	gitProvider             *domainFakes.FakeGitProvider
 	issueTrackerProvider    *domainFakes.FakeIssueTrackerProvider
@@ -28,6 +27,10 @@ type CreatePullRequestExecutionTestSuite struct {
 	repositoryProvider      *domainFakes.FakeRepositoryProvider
 }
 
+func (s *CreatePullRequestExecutionTestSuite) setGetBranchName(branchName string) {
+	s.branchProvider.EXPECT().GetBranchName(mock.Anything, mock.Anything, mock.Anything).Return(branchName, nil).Once()
+}
+
 type CreateGithubPullRequestExecutionTestSuite struct {
 	CreatePullRequestExecutionTestSuite
 }
@@ -36,10 +39,6 @@ func TestCreateGitHubPullRequestExecutionTestSuite(t *testing.T) {
 	suite.Run(t, new(CreateGithubPullRequestExecutionTestSuite))
 }
 
-func (s *CreateGithubPullRequestExecutionTestSuite) SetupSuite() {
-	s.defaultBranchName = "feature/GH-1-sample-issue"
-}
-
 func (s *CreateGithubPullRequestExecutionTestSuite) SetupSubTest() {
 	s.gitProvider = domainFakes.NewFakeGitProvider()
 	s.userInteractionProvider = s.initializeUserInteractionProvider()
@@ -158,7 +157,7 @@ func (s *CreateGithubPullRequestExecutionTestSuite) TestCreatePullRequestExecuti
 
 		err := s.uc.Execute()
 
-		s.ErrorContains(err, use_cases.ErrRemoteBranchAlreadyExists(s.defaultBranchName).Error())
+		s.ErrorContains(err, use_cases.ErrRemoteBranchAlreadyExists(branchName).Error())
 		s.assertCreatePullRequestNotCalled()
 	})
 
@@ -380,10 +379,6 @@ func TestCreateJiraPullRequestExecutionTestSuite(t *testing.T) {
 	suite.Run(t, new(CreateJiraPullRequestExecutionTestSuite))
 }
 
-func (s *CreateJiraPullRequestExecutionTestSuite) SetupSuite() {
-	s.defaultBranchName = "feature/PROJECTKEY-1-sample-issue"
-}
-
 func (s *CreateJiraPullRequestExecutionTestSuite) SetupTest() {
 	s.getConfigFile = config.GetConfigFile
 	dir, _ := os.Getwd()
@@ -515,7 +510,7 @@ func (s *CreateJiraPullRequestExecutionTestSuite) TestCreatePullRequestExecution
 
 		err := s.uc.Execute()
 
-		s.ErrorContains(err, use_cases.ErrRemoteBranchAlreadyExists(s.defaultBranchName).Error())
+		s.ErrorContains(err, use_cases.ErrRemoteBranchAlreadyExists(branchName).Error())
 		s.assertCreatePullRequestNotCalled()
 	})