NGI0 - Updating licensing aspects according REUSE #416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We have been working within the NGI0 framework, helping projects with their licensing and copyright management. After a quick check on your repository, I would like to propose some updates regarding copyright and licensing information. REUSE specifications intend to make licensing easier by setting one way to display all this legal information through comment headers on source files that can be human - and machine – readable.
The REUSE tool makes the process of applying licenses to files and compliance checking much easier. Check this screencast:
https://download.fsfe.org/videos/reuse/screencasts/reuse-tool.gif
Feel completely free to adopt these specifications by merging this pull request.
REUSE Features:
SPDX copyright and license comment headers for all relevant files (please notice that I added SPDX headers only to the files in
app/src/main/java/
directory.LICENSES directory with all licenses used on the repository (Please be aware that I added the general license GPLv3 and also the text of the Apache 2.0 and CC0 license, since the icons in
assets/
directory are under those licenses)Associating Copyright/ Licensing information through a DEP5 file in large directories (Keeping in mind that you have some large images directories e.g
assets/
I bulked licensing these files through a dep5. However, there are some other directories with more image files which I recommend to add to the dep5 file with the proper license and copyright information)Files missing copyright and licensing information:
I added the comment headers with copyright and license information to some of the files that lacked that information in
app/src/main/java/
directory.Please also double check if the personal information in the headers is correct and consistent.
I provided a more detailed license information to
README
file as well.In
.reuse
folder I have created a dep5 file to bulk licensing the large image directoryassets/
Note: There are more image files in the directory
app/src/main/res/drawable
I did not create any license file for that directory because I am not sure under what license it is and who is copyright holder. So please, check that directory and add the license/copyright information to the dep5 file.No contribution policy:
We have noticed that your project does not have a contribution policy. Therefore, we strongly recommend you to implement one. To get further information about this please check our documentation: https://download.fsfe.org/NGI0/V2/FSFE%20-%204%20-%20Free%20Software%20Contribution%20Policy.pdf
Further REUSE compliance
In case you find REUSE useful, we offer a wide range of tools to help you to continuously check and display compliance with the REUSE guidelines.
Hope that helps and thank you very much for the amazing job!