Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hpc access management menu to navbar #53

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Add hpc access management menu to navbar #53

merged 3 commits into from
Dec 12, 2024

Conversation

cc-a
Copy link
Collaborator

@cc-a cc-a commented Dec 11, 2024

Description

Adds a navbar item to Coldfront providing links related to the group membership functionality. Also adds a simple check_access view available for all users to report their current access status to HPC resources.

To test this branch you must use the navbar branch of imperialcollegelondon/coldfront_development_environment. This uses a bit of a hack to implement this functionality in the hopes that we can get proper support for doing this later. I have ubccr/coldfront#635 open to try and get upstream support for this.

Fixes # (issue)

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@cc-a cc-a linked an issue Dec 11, 2024 that may be closed by this pull request
Copy link
Contributor

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! After I realised I needed to re-build the docker image to include the changes in the other repo, this worked as expected!

Do we need a test for the check_access view?

imperial_coldfront_plugin/views.py Show resolved Hide resolved
@cc-a
Copy link
Collaborator Author

cc-a commented Dec 12, 2024

@AdrianDAlessandro I will add a test in #54 after merging this.

# Conflicts:
#	imperial_coldfront_plugin/views.py
@cc-a cc-a enabled auto-merge December 12, 2024 17:48
@cc-a cc-a merged commit 9bf768c into main Dec 12, 2024
4 checks passed
@cc-a cc-a deleted the nav-bar branch December 12, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add group management features to nav bar
2 participants