Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pages deployment variable logic and fixes in github pages yaml files #1337

Merged
merged 13 commits into from
Nov 21, 2024
Merged

Add pages deployment variable logic and fixes in github pages yaml files #1337

merged 13 commits into from
Nov 21, 2024

Conversation

Hristo313
Copy link
Contributor

@Hristo313 Hristo313 commented Nov 11, 2024 •
edited
Loading

Depending on the PAGES_DEPLOYMENT repository variable, we should trigger the GitHub Pages deployment workflow.
Rename github.io to github-pages.

@Hristo313 Hristo313 requested a review from Lipata November 11, 2024 13:50
@coveralls
Copy link

coveralls commented Nov 11, 2024 •
edited
Loading

Coverage Status

coverage: 70.454%. remained the same
when pulling 6321dbb on hhristov/add-github-pages-deployment-flag-in-yaml
into 412a2a5 on master.

@Hristo313 Hristo313 changed the title Add generate deployment script flag in yaml files Add pages deployment logic in yaml files Nov 13, 2024
@Hristo313 Hristo313 changed the title Add pages deployment logic in yaml files Add pages deployment logic and fixes in yaml files Nov 13, 2024
@Hristo313 Hristo313 changed the title Add pages deployment logic and fixes in yaml files Add pages deployment logic and fixes in github pages yaml files Nov 13, 2024
@Hristo313 Hristo313 changed the title Add pages deployment logic and fixes in github pages yaml files Add pages deployment variable logic and fixes in github pages yaml files Nov 13, 2024
@Lipata Lipata merged commit c75d9c7 into master Nov 21, 2024
3 checks passed
@Lipata Lipata deleted the hhristov/add-github-pages-deployment-flag-in-yaml branch November 21, 2024 07:39
@Lipata Lipata mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lipata Lipata Lipata approved these changes

Assignees

@Lipata Lipata

Labels
angular-modules angular-standalone react web-components ✅ status: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hristo313 @coveralls @Lipata