feat(igr-ts): add igr-ts proj type #1146
Conversation
igdmdimitrov
changed the base branch from
mtsvyatkova/use-react-functions
to
master
packages/cli/templates/react/igr-ts-es6/projects/_base/files/src/serviceWorker.tsx
Outdated
Show resolved
Hide resolved
packages/cli/templates/react/igr-ts-es6/projects/_base/files/src/views/home/style.module.css
Outdated
Show resolved
Hide resolved
|
@onlyexeption Assuming the existing Ignite UI for React project was |
# Conflicts: # packages/cli/package.json # packages/core/package.json # packages/igx-templates/package.json # packages/ng-schematics/package.json
gedinakova
added
💥 status: in-test
✅ status: verified
and removed
❌ status: awaiting-test
💥 status: in-test
labels
There was a problem hiding this comment.
Mostly really minor and cosmetic changes and a few notes:
I tried generating a React legacy project, but the cli threw, so we may want to fix that until it is completely removed.
Additionally, the TypeScriptFileUpdate for WC & NG and the ReactTypeScriptFileUpdate files are in need of some major refactoring (which we may want to prioritize) as they are clones for the most part and we should try to extract some logic into a base file.
...i/templates/react/igr-ts/bullet-graph/default/files/src/app/__path__/__filePrefix__.test.tsx
Outdated
Show resolved
Hide resolved
packages/cli/templates/react/igr-ts/projects/_base/files/src/setupTests.ts
Outdated
Show resolved
Hide resolved
packages/cli/templates/react/igr-ts/projects/_base_with_home/files/src/app/home/home.tsx
Outdated
Show resolved
Hide resolved
packages/cli/templates/react/igr-ts/projects/top-nav/files/src/app/App.css
Outdated
Show resolved
Hide resolved
...i/templates/react/igr-ts/radial-gauge/default/files/src/app/__path__/__filePrefix__.test.tsx
Outdated
Show resolved
Hide resolved
...ages/cli/templates/react/igr-ts/radial-gauge/default/files/src/app/__path__/style.module.css
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
There's still a little problem with the legacy React projects - because of outdated versions it will fail to compile/run. The problem occurs on newer versions of nodejs (17+) and since we can drop the legacy project entirely (on the next major cli version), there shouldn't be a need to tackle this issue. #1176
|
@ChronosSF, @damyanpetev I'm merging this PR and we should decide if we can release without fixing #1176. |
Closes # .
Closes #1147
Closes #1153
Closes #1158
Closes #1159