Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-builder): exit edit mode on chip/add button click #15207

Conversation

teodosiah
Copy link
Contributor

@teodosiah teodosiah commented Jan 7, 2025

Closes #14647 (comment)

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@teodosiah teodosiah changed the title fix(query-builder): exit edit mode on item click fix(query-builder): exit edit mode on chip/add button click Jan 7, 2025
@teodosiah teodosiah marked this pull request as ready for review January 8, 2025 08:27
@teodosiah teodosiah requested a review from gedinakova January 8, 2025 08:33
@teodosiah teodosiah added ❌ status: awaiting-test PRs awaiting manual verification query-builder labels Jan 8, 2025
@gedinakova gedinakova self-assigned this Jan 8, 2025
@gedinakova gedinakova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jan 8, 2025
@gedinakova
Copy link
Contributor

@teodosiah

  1. Put the first condition (the subquery) in edit mode
  2. Click the add button on "Validated"
    Result: The sub-query is collapsed and the drop-down remains outside the QB.
screen-capture.12.webm

@gedinakova
Copy link
Contributor

gedinakova commented Jan 8, 2025

@teodosiah Edit mode should be exited on another chip drag start or delete button click as well.

screen-capture.13.webm

@teodosiah teodosiah requested review from igdmdimitrov and removed request for gedinakova January 8, 2025 09:51
@gedinakova
Copy link
Contributor

@teodosiah Edit mode should be exited on another chip drag start or delete button click as well.

screen-capture.13.webm

The only two things remaining are (and I am not sure if the second is supposed to exit edit mode, but I think it would be better if it does):

  1. Clicking on the And/Or group expander to change the group.
  2. Clicking in the entity & return fields drop-downs.

@gedinakova
Copy link
Contributor

@teodosiah One final issue:

  1. Edit a condion in the inner query, e.g. change Boolean from "true" to " false"
  2. Click on an add button of a condition outside the inner query
  3. Expand the inner query

Result: The boolean value is not updated.

screen-capture.webm

@teodosiah teodosiah requested a review from gedinakova January 20, 2025 16:14
@gedinakova
Copy link
Contributor

gedinakova commented Jan 21, 2025

@teodosiah Sub-query condition state is still reverted and exits edit mode on clicking the delete button on a chip from outer query or the group context menu.

@gedinakova gedinakova merged commit e7b8e47 into ipetrov/query-builder-drag-and-drop-nogap Jan 22, 2025
@gedinakova gedinakova deleted the thristodorova/query-builder-exit-edit-mode branch January 22, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 status: in-test PRs currently being tested query-builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants