-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query-builder): exit edit mode on chip/add button click #15207
fix(query-builder): exit edit mode on chip/add button click #15207
Conversation
screen-capture.12.webm |
@teodosiah Edit mode should be exited on another chip drag start or delete button click as well. screen-capture.13.webm |
…ithub.com/IgniteUI/igniteui-angular into thristodorova/query-builder-exit-edit-mode
projects/igniteui-angular/src/lib/query-builder/query-builder-tree.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/query-builder/query-builder-tree.component.ts
Outdated
Show resolved
Hide resolved
The only two things remaining are (and I am not sure if the second is supposed to exit edit mode, but I think it would be better if it does):
|
projects/igniteui-angular/src/lib/query-builder/query-builder-tree.component.ts
Outdated
Show resolved
Hide resolved
@teodosiah One final issue:
Result: The boolean value is not updated. screen-capture.webm |
…ithub.com/IgniteUI/igniteui-angular into thristodorova/query-builder-exit-edit-mode
…ithub.com/IgniteUI/igniteui-angular into thristodorova/query-builder-exit-edit-mode
…github.com/IgniteUI/igniteui-angular into thristodorova/query-builder-exit-edit-mode
…ithub.com/IgniteUI/igniteui-angular into thristodorova/query-builder-exit-edit-mode
@teodosiah Sub-query condition state is still reverted and exits edit mode on clicking the delete button on a chip from outer query or the group context menu. |
…ithub.com/IgniteUI/igniteui-angular into thristodorova/query-builder-exit-edit-mode
Closes #14647 (comment)
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)