fix(select): fix memory leak in IgxSelectionAPIService #13926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodosiah
added
version: 17.1.x
🛠️ status: in-development
teodosiah
added
❌ status: awaiting-test
Lipata
approved these changes
Feb 20, 2024
| * Removes selection for a component. | ||
| * @param componentID | ||
| */ | ||
| public delete(componentID: string) { |
There was a problem hiding this comment.
Once the selection service is provided on a component level instead of on the root this will not be necessary.
Lipata
added
💥 status: in-test
|
In addition to the sample that is provided in the bug, I've tested samples with a grid with paging (which contains select) and a grid with select as an editor provider. |
Lipata
added
✅ status: verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13923
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)