Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sales Grid app. #2

Merged
merged 16 commits into from
Dec 11, 2024
Merged

Add Sales Grid app. #2

merged 16 commits into from
Dec 11, 2024

Conversation

skrustev
Copy link
Member

@skrustev skrustev commented Dec 2, 2024

No description provided.

@skrustev skrustev marked this pull request as ready for review December 3, 2024 10:41
@dkamburov
Copy link
Collaborator

  1. There is an error in the console, even though the sample is running:
    image
  2. Clicking on Store dimension is really slow action, makes the grid not responsive for more than 10 seconds(or dragging the periods column). Is it related to the data being bigger than it is in the samples? And what can we do about it?
  3. The grid is not taking the whole space of the document. Is this by design?
    image

@skrustev
Copy link
Member Author

skrustev commented Dec 5, 2024

@dkamburov

  1. This error is throwing only when running the sample locally using npm start. Running it as a client there are no such errors, so I am not sure what could it be yet.
  2. The data used currently for the sample is 100 000 records yes. It takes a bit for it to be processed into dimensions through the pipes. Maybe a product feature would be to make the grid not lock the window and display a loading screen when doing such operations, but that is not present at the moment.
  3. For now I've made it similar to the design size. When the whole app is created it can be tweaked to fit the parent container, whatever size it is.

projects/SalesGrid/angular.json Outdated Show resolved Hide resolved
projects/SalesGrid/src/app/app.routes.ts Outdated Show resolved Hide resolved
projects/SalesGrid/src/index.html Outdated Show resolved Hide resolved
@skrustev skrustev requested a review from mddragnev December 5, 2024 15:13
@yradoeva

This comment was marked as resolved.

@yradoeva

This comment was marked as resolved.

@dkamburov dkamburov merged commit 32959a9 into master Dec 11, 2024
@dkamburov dkamburov deleted the skrastev/sales-grid branch December 11, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants