-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add different redirect options #197
Conversation
bfee188
to
f299762
Compare
TODO
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With Icinga/icingaweb2#5108 it's now possible to refresh only the column that would also be affected by any other redirect such as __CLOSE__
. (i.e. for modals, the opener)
Please rely on that for closeCurrentAndRefreshRelatedView
. Though, rename it to closeModalAndRefreshRelatedView
. I'd also suggest to add a second optional parameter which allows to define which column should be refreshed by an extra update in case of a legacy Web version.
Then, for the case where #col1
and #col2
should be refreshed, please add a new method. As name I'd suggest closeModalAndRefreshRemainingViews
and assume that the modal is always shown in #col2
so you can issue a __REFRESH__
and an extra update for #col1
. This is the only known case where refreshing both columns is required, so I think it's sufficient this way.
07e4cfb
to
a69d112
Compare
a69d112
to
0550a38
Compare
0550a38
to
e78a667
Compare
GitHub actions fail with function never exit execution or throw exception. |
Then we'll add the same doc return type to ActionController::redirectNow() |
e78a667
to
b76413c
Compare
Requires Icinga/icingaweb2#5110 |
b76413c
to
1713947
Compare
1713947
to
a64a8f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing: The url shouldn't be optional, should it? Any module not passing it, only supports Icinga Web v2.12, which isn't released yet anyway. I don't think anyone developing a module will only support the latest major, and support for 2.11.x won't end soon enough.
a64a8f2
to
01ee00e
Compare
TODO
col1
orcol2
DefineX-Icinga-Modal-Opener
request header icingaweb2#5105col1
it won't be refreshed when redirecting using__CLOSE__
Test commit:Icinga/icingaweb2-module-reporting#194