Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Fix cloning #103

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Query: Fix cloning #103

wants to merge 1 commit into from

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Apr 11, 2023

No description provided.

@nilmerg nilmerg added the bug Something isn't working label Apr 11, 2023
@nilmerg nilmerg added this to the v0.5.1 milestone Apr 11, 2023
@nilmerg nilmerg requested a review from lippserd April 11, 2023 08:04
@nilmerg nilmerg self-assigned this Apr 11, 2023
@cla-bot cla-bot bot added the cla/signed label Apr 11, 2023
@nilmerg
Copy link
Member Author

nilmerg commented Apr 11, 2023

@lippserd I remember we talked already about a similar problem already? (cloning something with a reference loop) Though, I don't remember exactly for which use case.

Base automatically changed from fix/passing-expressions-to-withColumns-is-broken-101 to main April 11, 2023 12:28
@lippserd
Copy link
Member

@lippserd I remember we talked already about a similar problem already? (cloning something with a reference loop) Though, I don't remember exactly for which use case.

I'm not quite sure if we were talking about a similar problem that this PR is trying to solve.
The only discussion I recall is the proper cloning of our HTML elements.

@nilmerg nilmerg removed this from the v0.5.1 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants