Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected kiosk mode config #5281

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Corrected kiosk mode config #5281

merged 3 commits into from
Oct 30, 2024

Conversation

log1-c
Copy link
Contributor

@log1-c log1-c commented Oct 29, 2024

Only got the documented steps to work if the [autologin] part was added, so I suppose it is missing from this documentation

Only got the documented steps to work if the [autologin] part was added, so I suppose it is missing from this documentation
@cla-bot cla-bot bot added the cla/signed label Oct 29, 2024
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop the example and link to 05-Authentication.md#authentication-configuration-external-authentication instead. I also don't see a need for the configuration path here.

And please capitalize the first word of a new sentence. ;)

@log1-c
Copy link
Contributor Author

log1-c commented Oct 29, 2024

@nilmerg
Added the link (though I personally don't see the benefit of "jumping" to another docs page for just two lines of code).
Full path was used because it is used everywhere else in this docs page as well.

Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, ok, but the link points to the main location where external auth is described. In case the config ever changes, it's just a single place to update.

@nilmerg
Copy link
Member

nilmerg commented Oct 30, 2024

Eh, and thank you :D

@nilmerg nilmerg merged commit 2864e60 into Icinga:main Oct 30, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants