Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not clone jobs #222

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Do not clone jobs #222

merged 3 commits into from
Nov 14, 2023

Commits on Nov 10, 2023

  1. Don't clone Job instance

    @yhabteab
    yhabteab committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    86e11d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Don't override scheduled jobs with the new ones 

    Before Icinga PHP Library `<=0.13.0`, the scheduler was using the PHP
standard `SplObjectStorage`, which automatically generates a unique hash
whenever adding a new task using `attach()`. This hash was generated
internally with `spl_object_hash()`. As a result, when we try to remove
a job from the scheduler that was scheduled e.g `5m` ago (since this is
the default daemon config reload interval), the scheduler crashes with
job `foo` not scheduled.
    @yhabteab
    yhabteab committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    73ba000 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Lazily initialize Job uuid

    @yhabteab
    yhabteab committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    ba5c6e3 View commit details
    Browse the repository at this point in the history