Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test icingadb.EntitiesById #804

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
149 changes: 149 additions & 0 deletions pkg/icingadb/entitiesbyid_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,149 @@
package icingadb

import (
"context"
"github.com/icinga/icinga-go-library/database"
"github.com/icinga/icinga-go-library/types"
"github.com/icinga/icingadb/pkg/icingadb/v1"
"github.com/stretchr/testify/require"
"testing"
"time"
)

func TestEntitiesById_Keys(t *testing.T) {
subtests := []struct {
name string
input EntitiesById
output []string
}{
{name: "nil"},
{
name: "empty",
input: EntitiesById{},
},
{
name: "one",
input: EntitiesById{"one": nil},
output: []string{"one"},
},
{
name: "two",
input: EntitiesById{"one": nil, "two": &v1.EntityWithoutChecksum{}},
output: []string{"one", "two"},
},
}

for _, st := range subtests {
t.Run(st.name, func(t *testing.T) {
require.ElementsMatch(t, st.output, st.input.Keys())
})
}
}

func newEntity(id []byte) *v1.EntityWithoutChecksum {
return &v1.EntityWithoutChecksum{IdMeta: v1.IdMeta{Id: id}}
}

func TestEntitiesById_IDs(t *testing.T) {
subtests := []struct {
name string
input EntitiesById
output []types.Binary
}{
{name: "nil"},
{
name: "empty",
input: EntitiesById{},
},
{
name: "one",
input: EntitiesById{"one": newEntity([]byte{23})},
output: []types.Binary{{23}},
},
{
name: "two",
input: EntitiesById{"one": newEntity([]byte{23}), "two": newEntity([]byte{42})},
output: []types.Binary{{23}, {42}},
},
}

for _, st := range subtests {
t.Run(st.name, func(t *testing.T) {
require.ElementsMatch(t, st.output, st.input.IDs())
})
}
}

func TestEntitiesById_Entities(t *testing.T) {
subtests := []struct {
name string
io EntitiesById
}{
{name: "nil"},
{
name: "empty",
io: EntitiesById{},
},
{
name: "one",
io: EntitiesById{"one": newEntity([]byte{23})},
},
{
name: "two",
io: EntitiesById{"one": newEntity([]byte{23}), "two": newEntity([]byte{42})},
},
}

for _, st := range subtests {
t.Run(st.name, func(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()

expected := make([]database.Entity, 0, len(st.io))
actual := make([]database.Entity, 0, len(st.io))

for _, v := range st.io {
expected = append(expected, v)
}

ch := st.io.Entities(ctx)
require.NotNil(t, ch)

for range expected {
select {
case v, ok := <-ch:
require.True(t, ok, "channel closed too early")
actual = append(actual, v)
case <-time.After(time.Second):
require.Fail(t, "channel should not block")
}
}

require.ElementsMatch(t, expected, actual)

select {
case v, ok := <-ch:
require.False(t, ok, "channel should be closed, got %#v", v)
case <-time.After(time.Second):
require.Fail(t, "channel should not block")
}
})
}

t.Run("closed-ctx", func(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background())
cancel()

ch := EntitiesById{"one": newEntity([]byte{23})}.Entities(ctx)
require.NotNil(t, ch)

time.Sleep(time.Millisecond)

select {
case v, ok := <-ch:
require.False(t, ok, "channel should be closed, got %#v", v)
case <-time.After(time.Second):
require.Fail(t, "channel should not block")
}
})
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one case not tested in EntitiesById.Entities:

case <-ctx.Done():
return

Thus, please add another test case with a prematurely closed context.

Loading