Integration tests: include MariaDB as well #729
Conversation
| @@ -17,8 +17,13 @@ jobs: | |||
| database: | |||
| - name: mysql | |||
| pretty_name: MySQL | |||
| image: mysql:latest | |||
| - name: mysql | |||
There was a problem hiding this comment.
Having another test named mysql actually being MariaDB is a bit confusing. Why not setting the name to what it is and introduce another field matching ICINGADB_TESTS_DATABASE_TYPE, e.g., database_type?
There was a problem hiding this comment.
Please have a look at https://github.com/Icinga/icingadb/blob/main/.github/workflows/sql.yml. This also avoids setting variables like ICINGA_TESTING_PGSQL_IMAGE: mysql:latest.
There was a problem hiding this comment.
Yes, a such env var is a bit cheaty, but I prefer a nice looking matrix with the DB type written just one (lowercase).
There was a problem hiding this comment.
Yes, a such env var is a bit cheaty,
And setting ICINGA_TESTING_PGSQL_IMAGE: mysql:latest is not cheaty at all?
but I prefer a nice looking matrix with the DB type written just one
You mean once? https://github.com/Icinga/icingadb/blob/main/.github/workflows/sql.yml doesn't repeat it any more than the current version of this PR.
(lowercase).
That sounds just like an arbitrary choice. Sure, if both were otherwise identical, I'd also pick lowercase, but they aren't: it's easier to make the string lowercase in our Go code than in GitHub Actions Workflow YAML. And I don't think "I prefer lowercase" is a reasonable argument to completely rule out the alternative.
There was a problem hiding this comment.
No, setting such an env var IS cheaty of course (as I said), but I prefer it over
- having to lower/upper-case something somewhere
- having to repeat the database type more than once in the matrix
There was a problem hiding this comment.
Please have a look at https://github.com/Icinga/icingadb/blob/main/.github/workflows/sql.yml. This also avoids setting variables like
ICINGA_TESTING_PGSQL_IMAGE: mysql:latest.
I don't understand why it is not done exactly as in the referenced file.
Al2Klimov
force-pushed
the
Al2Klimov-patch-2
branch
from
9a88abc
to
55f0e41
Compare
| @@ -51,6 +58,6 @@ jobs: | |||
| if: ${{ always() }} | |||
| uses: actions/upload-artifact@v2 | |||
| with: | |||
| name: ${{ matrix.database.name }}-debug.log.xz | |||
| name: ${{ matrix.database.type }}-debug.log.xz | |||
There was a problem hiding this comment.
With this change, the debug log from MariaDB and MySQL are having the same filename now. I would advise to revert this.
Al2Klimov
force-pushed
the
Al2Klimov-patch-2
branch
from
55f0e41
to
5aa7439
Compare
just to be sure we're compatible with this RDBMS and not only MySQL.
Al2Klimov
force-pushed
the
Al2Klimov-patch-2
branch
from
5aa7439
to
41c31f2
Compare
just to be sure we're compatible with this RDBMS and not only MySQL.