-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten(): render even large numbers as-is, not using scientific notation #657
Conversation
Anyway, the tests don't have to wait for the implementation details. Part of the tests should be to verify that the implementation isn't changed in other ways, so please add them as a first commit so that they pass on the old implementation and then add another case for large floats with the updated implementation. |
4a10a66
to
383a6f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reorder the commits so that that the tests are added first without the 1e23
case, so that when the tests are run on this commit, it shows that the old implementation conforms to the tests, and then fixing the implementation including an additional test case, showing that the new implementation passes the same tests as the old one plus a new one.
…tion E.g. 2000000000000000000 (explicitly), not 2e+18 (as with fmt.Sprintf("%v")).
383a6f9
to
e2fc769
Compare
E.g. 2000000000000000000 (explicitly), not 2e+18 (as with fmt.Sprintf("%v")).
fixes #659
TODO