MySQL: Use strict SQL mode instead of just ANSI_QUOTES

Icinga · Jul 31, 2023 · 9e7f109 · 9e7f109
1 parent 204f727
commit 9e7f109
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pkg/config/database.go b/pkg/config/database.go
@@ -61,7 +61,8 @@ func (d *Database) Open(logger *logging.Logger) (*icingadb.DB, error) {
 
 		config.DBName = d.Database
 		config.Timeout = time.Minute
-		config.Params = map[string]string{"sql_mode": "ANSI_QUOTES"}
+		// Set strict SQL mode, i.e. trigger an error if an incorrect value is inserted into a column.
+		config.Params = map[string]string{"sql_mode": "TRADITIONAL"}
 
 		tlsConfig, err := d.TlsOptions.MakeConfig(d.Host)
 		if err != nil {

diff --git a/pkg/icingadb/quoter.go b/pkg/icingadb/quoter.go
@@ -20,7 +20,7 @@ func NewQuoter(db *sqlx.DB) *Quoter {
 
 	switch db.DriverName() {
 	case driver.MySQL:
-		qc = `"`
+		qc = "`"
 	case driver.PostgreSQL:
 		qc = `"`
 	default: