Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomVarRendererHook: Log an exception's message and location #1086

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions library/Icingadb/Hook/CustomVarRendererHook.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ final public static function prepareForObject(Model $object): Closure
$hooks[] = $hook;
}
} catch (Throwable $e) {
Logger::error('Failed to load hook %s:', get_class($hook), $e);
Logger::error('Failed to load hook %s: %s', get_class($hook), $e);
Logger::debug($e);
}
}

Expand All @@ -85,7 +86,8 @@ final public static function prepareForObject(Model $object): Closure
$renderedValue = $hook->renderCustomVarValue($key, $value);
$group = $hook->identifyCustomVarGroup($key);
} catch (Throwable $e) {
Logger::error('Failed to use hook %s:', get_class($hook), $e);
Logger::error('Failed to use hook %s: %s', get_class($hook), $e);
Logger::debug($e);
continue;
}

Expand Down
Loading