(Host/Service)groupController: Remove obsolete setSuggestionUrl() call
#1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
fix-hostgroup-search-editor
branch
2 times, most recently
from
0eadf61
to
c2d23a6
Compare
nilmerg
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Since this also affects the servicegroup detail (which you should have noticed yourself, to be honest) and maybe several others (didn't further check), please find a more general solution. createSearchEditor already knows about parameters to preserve, so it is potentially a good idea to also pass them automatically to the suggestion url. As long as this doesn't have any negative side-effects (as not only name is passed then), I'd prefer this.
sukhwinder33445
force-pushed
the
fix-hostgroup-search-editor
branch
2 times, most recently
from
0882dfe
to
c31096f
Compare
sukhwinder33445
changed the title
setSuggestionUrl() call(Host/Service)groupController: Remove obsolete setSuggestionUrl() call
…ditor) suggestionUrl SuggestionUrl now uses the preserveParams as default params
sukhwinder33445
force-pushed
the
fix-hostgroup-search-editor
branch
from
c31096f
to
2bf7897
Compare
nilmerg
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require: Icinga/ipl-web#233