-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document host Common Runtime Attribute #9883
Conversation
That attribute is not just present in |
454dc87
to
bdfb1dd
Compare
@julianbrost: Thanks for the clarification. I found it in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Julian, what do you think?
@@ -731,7 +732,6 @@ Configuration Attributes: | |||
event\_command | Object name | **Optional.** The name of an event command that should be executed every time the service's state changes or the service is in a `SOFT` state. | |||
volatile | Boolean | **Optional.** Treat all state changes as HARD changes. See [here](08-advanced-topics.md#volatile-services-hosts) for details. Defaults to `false`. | |||
zone | Object name | **Optional.** The zone this object is a member of. Please read the [distributed monitoring](06-distributed-monitoring.md#distributed-monitoring) chapter for details. | |||
name | String | **Required.** The service name. Must be unique on a per-host basis. For advanced usage in [apply rules](03-monitoring-basics.md#using-apply) only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether to remove it. This one is on a per-host basis, ...
doc/09-object-types.md
Outdated
@@ -34,6 +34,7 @@ the [Icinga 2 API](12-icinga2-api.md#icinga2-api-config-objects). | |||
templates | Array | Templates imported on object compilation. | |||
package | String | [Configuration package name](12-icinga2-api.md#icinga2-api-config-management) this object belongs to. Local configuration is set to `_etc`, runtime created objects use `_api`. | |||
source\_location | Dictionary | Location information where the configuration files are stored. | |||
name | String | Object name. Must be unique on a per-type basis. Might be used for advanced usage in [apply rules](03-monitoring-basics.md#using-apply) only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... but this one is unique on a per-type basis.
I mean I was somewhat surprised that the There should be some place in the documentation from which you should know that services on the same host need distinct names but multiple hosts can have services with identical names (or is that too obvious to explicitly write down?), but the service attributes don't look like the correct place for that, also given that the same restriction applies to |
Full ack! name=x enables you to name config objects not like config items. Which is already scary enough even if it doesn't break anything. So shall we document it at all?
Yep. |
Which part of the logical OR question was that a yes to? However, as the text in question is now part of the Common Runtime Attributes section, couldn't we just remove the uniqueness note? |
Yes, the text before the table with these attributes says "which cannot be modified by the user", so I mean that isn't the place you look for naming your objects anyways. |
bdfb1dd
to
2b259ca
Compare
Okay thanks. I have just pushed an updated version. |
2b259ca
to
5310063
Compare
While being present in the attribute list for the Service object, the Host's name field is missing in the list of all attributes, even when being referred to in multiple examples of
assign where
.It is also present in the REST API's response: