Refresh #7786

[ymartin-ovh]

Refresh contribution in #7786

Regards

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Henrik Triem.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Henrik Triem.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[Al2Klimov]

Sorry, the bot is wrong. Please, on your branch, run git reset --hard f48cd6b19292c3c9eba5a6b2f1169f68ccfcefe0 and git push -f.

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Henrik Triem.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Henrik Triem.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[Al2Klimov]

@cla-bot check

[Al2Klimov]

What's the matter? You ran the command and I've even approved the PR. Why the additional force push? Sorry, but now you have to do this to fix this:

• git rebase -i e627dcce1bdfa48acd9b3bdf6a2bf4254e89ab43
• An editor will show up
  • remove all lines except your commit "Adapt WIP: Change the order of the API runtime object sync on reconnect #7786 to the new ConfigItem::CommitNewItems()"
  • save
  • exit
• git push -f

[ymartin-ovh]

What's the matter? You ran the command and I've even approved the PR. Why the additional force push? Sorry, but now you have to do this to fix this:

* `git rebase -i e627dcce1bdfa48acd9b3bdf6a2bf4254e89ab43`

* An editor will show up
  
  * remove all lines except your commit "Adapt [WIP: Change the order of the API runtime object sync on reconnect #7786](https://github.com/Icinga/icinga2/pull/7786) to the new ConfigItem::CommitNewItems()"
  * save
  * exit

* `git push -f`

I didn't realize it was you that change the destination branch. Working on it.

Regards

[Al2Klimov]

As @julianbrost pointed out, it makes no sense to merge this, yet. As this isn't definitely part of a release, yet. (TBD.) But the changes do exactly what they should. 👍

Just for the record, even this one seems not to fix the comment null deref issue you reported?

[ymartin-ovh]

Hello

About "Just for the record, even this one seems not to fix the comment null deref issue you reported?", yes this PR does not fix my null dereference.

Regards