Make ObjectImpl<Logger>#GetSeverity() non-virtual #9851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After all it's not overridden.
Al2Klimov
added
the
core/quality
|
How does marking only its setter method virtual make things even better? Marking only its setter as virtual makes no sense to me. |
|
Well, for a non-virtual method the address is known beforehand, but for a virtual one a lookup is required. And especially this method is called quite often. |
Why don't you remove the virtual keyword completely then? As I said before, it makes no sense to mark a setter of an attribute as virtual, but not its getter as well. We only have one logger type anyway, so why do we want to mark any of its methods as virtual? |
|
Well, simply because we override it. |
yhabteab
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After all it's not overridden.