Initialize Configuration#Concurrency from /sys/fs/cgroup/... #7845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO
|
|
... e.g. |
Al2Klimov
force-pushed
the
feature/concurrency-docker-7842
branch
from
5793b4e
to
66b84be
Compare
Al2Klimov
changed the title
MacOSCentOSDocker |
|
@cla-bot check |
julianbrost
requested changes
Jan 24, 2023
There was a problem hiding this comment.
Doesn't work with cgroup2, there the information is in /sys/fs/cgroup/cpu* files (i.e. not in extra subdirectories).
In general, an overview of how the Docker options map to cgroup attributes (and therefore which of these options this PR takes into account) would be nice. Looking at the corresponding systemd options is probably also interesting and they do properly document the cgroup options affected.
| int Configuration::Concurrency{static_cast<int>(std::thread::hardware_concurrency())}; | ||
|
|
||
| #ifdef __linux__ | ||
| static std::string ReadSysLine(const char *file) |
There was a problem hiding this comment.
This function looks overly complex for what it does. Shouldn't this basically be the same as std::ifstream + std::getline? The only thing I see that wouldn't be possible with that is the check for ENOENT. If this is just for kernel version compatibility, using an extra check would be fine. If this file can (dis)appear at runtime (changing the cgroup options, moving the process between cgroups), have a look at boost::iostreams like it's already used in AtomicFile.
lib/base/configuration.cpp
Outdated
| return ""; | ||
| } | ||
|
|
||
| throw system_error(error_code(errno, system_category())); |
There was a problem hiding this comment.
Do we really want to fail starting in this case? I think logging a warning and continuing with the value from std::thread::hardware_concurrency() would be a better option.
There was a problem hiding this comment.
- In "this case" a kernel subsystem(!) is out of service. The best reason to panic.
- Logging? We're in a static constructor.
|
|
TODO @Al2Klimov
|
Al2Klimov
force-pushed
the
feature/concurrency-docker-7842
branch
from
66b84be
to
1d6ab00
Compare
|
Doesn’t whoever controls the container spec also control the command it runs? I.e. can't they just set -DConfiguration.Concurrency= in addition to --cpu-whatever? I.e. do we need this PR? |
Most likely yes.
Not strictly needed as it can be worked around. However, the user has to be aware of this and it would be nice if Icinga would just do the correct thing by itself. |
Al2Klimov
force-pushed
the
feature/concurrency-docker-7842
branch
from
1d6ab00
to
cda810d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... not to try to consume more hardware resources than the admin assigned.
fixes #7842