JsonRpcConnection: Don't read any data on shutdown #10213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
added
bug
Al2Klimov
reviewed
Oct 31, 2024
yhabteab
added
consider backporting
yhabteab
force-pushed
the
do-not-read-data-on-disconnect
branch
from
b9cbe94
to
933abc3
Compare
When the `Desconnect()` method is called, clients are not disconnected immediately. Instead, a new coroutine is spawned using the same strand as the other coroutines. This coroutine calls `async_shutdown` on the TCP socket, which might be blocking. However, in order not to block indefintely, the `Timeout` class cancels all operations on the socket after `10` seconds. Though, the timeout does not trigger the handler immediately; it creates spawns another coroutine using the same strand as in the `JsonRpcConnection` class. This can cause unexpected delays if e.g. `HandleIncomingMessages` gets resumed before the coroutine from the timeout class. Apart from that, the coroutine for writing messages uses the same condition, making the two symmetrical.
yhabteab
force-pushed
the
do-not-read-data-on-disconnect
branch
from
933abc3
to
1c34610
Compare
yhabteab
requested review from
Al2Klimov and
julianbrost
and removed request for
julianbrost and
Al2Klimov
Al2Klimov
approved these changes
Oct 31, 2024
julianbrost
approved these changes
Nov 6, 2024
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
Desconnect()method is called, clients are not disconnected immediately. Instead, a new coroutine is spawned using the same strand as the other coroutines. This coroutine callsasync_shutdownon the TCP socket, which might be blocking. However, in order not to block indefintely, theTimeoutclass cancels all operations on the socket after10seconds. Though, the timeout does not trigger the handler immediately; it spawns another coroutine using the same strand as in theJsonRpcConnectionclass. This can cause unexpected delays if e.g.HandleIncomingMessagesgets resumed before the coroutine from the timeout class. Apart from that, the coroutine for writing messages uses the same condition, making the two symmetrical.I noticed this while analyzing the logs from ref/NC/820479.