Schedule redesign #183
Merged
Schedule redesign #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
added
enhancement
nilmerg
force-pushed
the
schedule-redesign
branch
3 times, most recently
from
892ad22
to
a64abe5
Compare
nilmerg
force-pushed
the
schedule-redesign
branch
10 times, most recently
from
8bbee2c
to
e760e2c
Compare
nilmerg
force-pushed
the
schedule-redesign
branch
from
2fa84ef
to
99b7187
Compare
nilmerg
force-pushed
the
schedule-redesign
branch
7 times, most recently
from
6e889b4
to
0701662
Compare
nilmerg
force-pushed
the
schedule-redesign
branch
2 times, most recently
from
3f5da78
to
95e04cc
Compare
nilmerg
force-pushed
the
schedule-redesign
branch
from
606a1fb
to
76132f9
Compare
This generalizes the CSS somewhat so that it applies to the new timeline without too much boilerplate.
Think of splitting this up...
grid-gap seems to negate the effect of minmax used to prevent a grid blowout. It's also wrong to apply it on the overlay anyway..
By transferring this responsibility, case specific optimizations are possible.
I'm still not convinced that this is good enough.
nilmerg
force-pushed
the
schedule-redesign
branch
from
76132f9
to
9247d7c
Compare
ncosta-ic
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Disclaimer: This is not a code-review. I just tested the functionalities provided and changed by this PR.
All rotation modes can be configured correctly and the resulting schedule is correct as well.
The rotations keep their defined date and there are no time derivations or gaps when adding or modifying them.
Additionally, all values are correctly saved into the database table. I was not able to produce data corruptions by using the web ui.
sukhwinder33445
added a commit
that referenced
this pull request
Jun 13, 2024
resolves #200 blocked by #183 blocked by Icinga/icinga-notifications#218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #177
Requirements