Don't decode the filter url

Leave this to QueryString::fromString() method.
Icinga · Jul 16, 2024 · 8838575 · 8838575
1 parent 4aa08e0
commit 8838575
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/application/controllers/ApiV1ChannelsController.php b/application/controllers/ApiV1ChannelsController.php
@@ -43,7 +43,7 @@ public function indexAction(): void
         }
 
         try {
-            $filterRule = QueryString::fromString(rawurldecode(Url::fromRequest()->getQueryString()))
+            $filterRule = QueryString::fromString(Url::fromRequest()->getQueryString())
                 ->on(
                     QueryString::ON_CONDITION,
                     function (Filter\Condition $condition) {

diff --git a/application/controllers/ApiV1ContactgroupsController.php b/application/controllers/ApiV1ContactgroupsController.php
@@ -61,7 +61,7 @@ public function indexAction(): void
             $this->httpBadRequest('The given identifier is not a valid UUID');
         }
 
-        $filterStr = rawurldecode(Url::fromRequest()->getQueryString());
+        $filterStr = Url::fromRequest()->getQueryString();
         if ($method !== 'GET' && $filterStr) {
             $this->httpBadRequest('Filter is only allowed for GET requests');
         }

diff --git a/application/controllers/ApiV1ContactsController.php b/application/controllers/ApiV1ContactsController.php
@@ -66,7 +66,7 @@ public function indexAction(): void
             $this->httpBadRequest('The given identifier is not a valid UUID');
         }
 
-        $filterStr = rawurldecode(Url::fromRequest()->getQueryString());
+        $filterStr = Url::fromRequest()->getQueryString();
         if ($method !== 'GET' && $filterStr) {
             $this->httpBadRequest('Filter is only allowed for GET requests');
         }