Skip to content

Commit

Permalink
Update GC bank section to be more accurate
Browse files Browse the repository at this point in the history
  • Loading branch information
Nicholas committed Feb 12, 2016
1 parent ccfe563 commit 5ec86d2
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions 1.905/fc_button.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -473,15 +473,15 @@ function FCMenu() {
buildTable.append($('<tr><td colspan="5">&nbsp;</td></tr>').css('border-top', '2px dashed #999'));

banks = [
{name: 'No Bank', cost: 0, efficiency: cookieEfficiency(Game.cookies, 0)},
{name: 'Lucky Bank', cost: luckyBank(), efficiency: cookieEfficiency(Game.cookies, luckyBank())},
{name: 'Lucky Frenzy Bank', cost: luckyFrenzyBank(), efficiency: cookieEfficiency(Game.cookies, luckyFrenzyBank())},
{name: 'Chain Bank', cost: chainBank(), efficiency: cookieEfficiency(Game.cookies, chainBank())}
{name: 'No Bank', cost: 0, efficiency: cookieEfficiency(0, 0)},
{name: 'Lucky Bank', cost: luckyBank(), efficiency: cookieEfficiency(0, luckyBank())},
{name: 'Lucky Frenzy Bank', cost: luckyFrenzyBank(), efficiency: cookieEfficiency(0, luckyFrenzyBank())},
{name: 'Chain Bank', cost: chainBank(), efficiency: cookieEfficiency(0, chainBank())}
];

banks.forEach(function(bank) {
var deltaCps = effectiveCps(bank.cost) - effectiveCps();
buildTable.append($('<tr><td colspan="2"><b>' + bank.name + (bank.deltaCps === 0 ? ' (*)' : '') + '</b></td><td>' + Beautify(bank.efficiency) + '</td><td>' + Beautify(Math.max(0, bank.cost - Game.cookies)) + '</td><td>' + Beautify(deltaCps) + '</td></tr>'));
buildTable.append($('<tr><td colspan="2"><b>' + bank.name + (deltaCps === 0 ? ' (*)' : '') + '</b></td><td>' + Beautify(bank.efficiency) + '</td><td>' + Beautify(bank.cost) + '</td><td>' + Beautify(deltaCps) + '</td></tr>'));
});
buildTable.append($('<tr><td colspan="5">&nbsp;</td></tr>'));
buildTable.append($('<tr><td colspan="5">&nbsp;</td></tr>').css('border-top', '2px dashed #999'));
Expand Down

1 comment on commit 5ec86d2

@valepakh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think previous display of (bank.cost - Game.cookies) was better - it showed the cookies remaining to this bank goal and showed 0 if the goal was reached. Now it always shows the cost, which is probably more consistent with the other costs, but slightly confusing.

Please sign in to comment.