[BlockSparseArrays] Fix nested slicing in Julia 1.11 #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 tasks
mtfishman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue listed in #1336 that was noticed in #1539 (which was dealt with in that PR by marking tests as broken) that some nested slicing operations broke in Julia 1.11. I think the cause was that some of the reindexing logic in SubArray changed and lead to views being created which we weren't handling properly.
The fix here is to impose that for some of our specialized index/slice objects, indexing is always eager, even if you try to take a view. This may not be the best long term solution, and probably we should make the indexing logic more generic to handle slices that are views to begin with, but it seems like a reasonable fix for the time being.