[BlockSparseArrays] Zero dimensional block sparse array and some fixes for Adjoint and PermutedDimsArray #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
changed the title
mtfishman
changed the title
59 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue brought up in #1336 (comment) that
BlockSparseArray{Float64}()failed. I also fixed getting and setting elements of zero dimensional block sparse arrays. Probably there is more functionality to fix but at least this is a good start.This also fixes an issue preserving axes duality when copying
a'(#1336 (comment)) and a printing issue witha'where the axes weren't being reversed properly.In the latest, I've also fixed a bug in
PermutedDimsArray(a, perm)that was raised here: #1336 (comment).Some code in this PR can be simplified once JuliaArrays/BlockArrays.jl#431 is merged.
To-do:
PermutedDimsArray(a, perm).copy(a').