Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SparseArrayDOKs] Add setindex_maybe_grow! and macro @maybe_grow #1434

Merged
merged 10 commits into from
May 14, 2024
Merged

[SparseArrayDOKs] Add setindex_maybe_grow! and macro @maybe_grow #1434

merged 10 commits into from
May 14, 2024

Commits on May 13, 2024

  1. Add maybe_grow features

    @emstoudenmire
    emstoudenmire committed May 13, 2024
    Configuration menu
    Copy the full SHA
    e74f478 View commit details
    Browse the repository at this point in the history

  2. Minor edits, add check in @maybe_grow macro

    @emstoudenmire
    emstoudenmire committed May 13, 2024
    Configuration menu
    Copy the full SHA
    320ac28 View commit details
    Browse the repository at this point in the history

  3. Improve syntax check for @maybe_grow

    @emstoudenmire
    emstoudenmire committed May 13, 2024
    Configuration menu
    Copy the full SHA
    4af4cc2 View commit details
    Browse the repository at this point in the history

  4. Improve readability

    @emstoudenmire
    emstoudenmire committed May 13, 2024
    Configuration menu
    Copy the full SHA
    41ef815 View commit details
    Browse the repository at this point in the history

  5. Use MacroTools in @maybe_grow

    @emstoudenmire
    emstoudenmire committed May 13, 2024
    Configuration menu
    Copy the full SHA
    625fa27 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Move expression check to separate function

    @emstoudenmire
    emstoudenmire committed May 14, 2024
    Configuration menu
    Copy the full SHA
    0520e67 View commit details
    Browse the repository at this point in the history

  2. Use dispatch to check setindex! expression

    @emstoudenmire
    emstoudenmire committed May 14, 2024
    Configuration menu
    Copy the full SHA
    7da8f09 View commit details
    Browse the repository at this point in the history

  3. Make dims field a Ref and remove mutable keyword

    @emstoudenmire
    emstoudenmire committed May 14, 2024
    Configuration menu
    Copy the full SHA
    93a65c6 View commit details
    Browse the repository at this point in the history

  4. Add and test constructor

    @emstoudenmire
    emstoudenmire committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c952653 View commit details
    Browse the repository at this point in the history

  5. Update NDTensors/src/lib/SparseArrayDOKs/src/sparsearraydok.jl 

    Avoid where syntax

Co-authored-by: Matt Fishman <[email protected]>
    @emstoudenmire @mtfishman
    emstoudenmire and mtfishman authored May 14, 2024
    Configuration menu
    Copy the full SHA
    aba62fd View commit details
    Browse the repository at this point in the history