Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITensors] Fix bugs in QN directsum and fermionic SVD #1178

Merged
merged 6 commits into from
Aug 12, 2023

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Aug 11, 2023

Description

#1176 introduced a bug in directsum of QN ITensors for cases when the directions of the indices that were passed to specify what indices should be direct-summed didn't match the directions of the internal indices of the tensors.

EDIT: Also fixes a bug introduced in #1174 when SVDing fermionic tensors with the auto fermion system disabled.

test/base/test_itensor.jl Outdated Show resolved Hide resolved
@mtfishman
Copy link
Member Author

[test ITensors mps]

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #1178 (c8028b0) into main (e6747cd) will decrease coverage by 18.06%.
The diff coverage is 100.00%.

❗ Current head c8028b0 differs from pull request most recent head e64bb65. Consider uploading reports for the commit e64bb65 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##             main    #1178       +/-   ##
===========================================
- Coverage   85.39%   67.33%   -18.06%     
===========================================
  Files          88       87        -1     
  Lines        8420     8367       -53     
===========================================
- Hits         7190     5634     -1556     
- Misses       1230     2733     +1503     
Files Changed Coverage Δ
src/global_variables.jl 100.00% <ø> (+3.33%) ⬆️
src/physics/fermions.jl 95.72% <100.00%> (-2.68%) ⬇️
src/tensor_operations/tensor_algebra.jl 87.09% <100.00%> (-3.04%) ⬇️

... and 35 files with indirect coverage changes

@github-actions
Copy link
Contributor

Run ITensors mps tests from comment trigger: failed ❌
https://github.com/ITensor/ITensors.jl/actions/runs/5837233019

1 similar comment
@github-actions
Copy link
Contributor

Run ITensors mps tests from comment trigger: failed ❌
https://github.com/ITensor/ITensors.jl/actions/runs/5837233019

@mtfishman
Copy link
Member Author

[test ITensors mps] [test ITensorGaussianMPS]

@github-actions
Copy link
Contributor

Run ITensorGaussianMPS tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/5842898927

1 similar comment
@github-actions
Copy link
Contributor

Run ITensorGaussianMPS tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/5842898927

@github-actions
Copy link
Contributor

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/5842898926

1 similar comment
@github-actions
Copy link
Contributor

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/5842898926

@mtfishman
Copy link
Member Author

[test ITensors mps] [test ITensorGaussianMPS]

@github-actions
Copy link
Contributor

Run ITensorGaussianMPS tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/5843114818

1 similar comment
@github-actions
Copy link
Contributor

Run ITensorGaussianMPS tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/5843114818

@github-actions
Copy link
Contributor

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/5843114817

1 similar comment
@github-actions
Copy link
Contributor

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/5843114817

@mtfishman mtfishman changed the title [ITensors] Fix bug in QN directsum [ITensors] Fix bugs in QN directsum and fermionic SVD Aug 12, 2023
@mtfishman mtfishman merged commit 8b82ad0 into main Aug 12, 2023
7 checks passed
@mtfishman mtfishman deleted the ITensors_directsum_qn_bug branch August 12, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants