-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ITensors] Fix bugs in QN directsum and fermionic SVD #1178
Conversation
[test ITensors mps] |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1178 +/- ##
===========================================
- Coverage 85.39% 67.33% -18.06%
===========================================
Files 88 87 -1
Lines 8420 8367 -53
===========================================
- Hits 7190 5634 -1556
- Misses 1230 2733 +1503
|
Run ITensors mps tests from comment trigger: failed ❌ |
1 similar comment
Run ITensors mps tests from comment trigger: failed ❌ |
[test ITensors mps] [test ITensorGaussianMPS] |
Run ITensorGaussianMPS tests from comment trigger: succeeded ✅ |
1 similar comment
Run ITensorGaussianMPS tests from comment trigger: succeeded ✅ |
Run ITensors mps tests from comment trigger: succeeded ✅ |
1 similar comment
Run ITensors mps tests from comment trigger: succeeded ✅ |
[test ITensors mps] [test ITensorGaussianMPS] |
Run ITensorGaussianMPS tests from comment trigger: succeeded ✅ |
1 similar comment
Run ITensorGaussianMPS tests from comment trigger: succeeded ✅ |
Run ITensors mps tests from comment trigger: succeeded ✅ |
1 similar comment
Run ITensors mps tests from comment trigger: succeeded ✅ |
Description
#1176 introduced a bug in
directsum
of QN ITensors for cases when the directions of the indices that were passed to specify what indices should be direct-summed didn't match the directions of the internal indices of the tensors.EDIT: Also fixes a bug introduced in #1174 when SVDing fermionic tensors with the auto fermion system disabled.