Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-sklearn baseline v1 #32

Open
wants to merge 66 commits into
base: main
Choose a base branch
from
Open

Auto-sklearn baseline v1 #32

wants to merge 66 commits into from

Conversation

AxiomAlive
Copy link
Collaborator

No description provided.

@AxiomAlive AxiomAlive changed the base branch from main to docker_and_experiments July 8, 2023 20:08
@MorrisNein
Copy link
Collaborator

MorrisNein commented Jul 20, 2023

Выполнил rebase ветки main на базовую. Не ожидал, что приведёт к такому количеству конфликтов. @algormx, доверите мне разрешение конфликтов между ветками?

@MorrisNein MorrisNein force-pushed the docker_and_experiments branch 2 times, most recently from 7cbe0a9 to c163054 Compare July 20, 2023 13:10
Copy link
Collaborator

@MorrisNein MorrisNein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Из ветки нужно убрать изменения для файлов, не относящихся к auto-sklearn baseline.

Советую делать git rebase вместо git merge, чтобы держать в чистоте историю коммитов

Comment on lines +116 to +124
# autosklearn_ensemble = pipeline.show_models()
# formatted_ensemble = {
# model_id: {
# 'rank': autosklearn_ensemble[model_id].get('rank'),
# 'cost': float(f"{autosklearn_ensemble[model_id].get('cost'):.3f}"),
# 'ensemble_weight': autosklearn_ensemble[model_id].get('ensemble_weight'),
# 'model': autosklearn_ensemble[model_id].get('sklearn_classifier')
# } for model_id in autosklearn_ensemble.keys()
# }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Комментарии с кодом лучше не добавлять в git, если они не служат для понимания остального кода. Можно сделать stash этих изменений, если есть необходимость их сохранить

Аналогично для остального закомментированного кода

.parse_datasets('test')
.loc[:, 'dataset_id']
]
# dataset_ids_to_load = [dataset_ids_to_load[dataset_ids_to_load.index(41166)]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно убрать комментарий

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Этот файл точно нужен в git фреймворка?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Аналогично, нужен ли этот файл в git?

@MorrisNein MorrisNein force-pushed the docker_and_experiments branch 3 times, most recently from 514d1fa to 3ae2f37 Compare November 7, 2023 14:42
@MorrisNein MorrisNein force-pushed the docker_and_experiments branch 4 times, most recently from 59cf07e to f23c206 Compare December 14, 2023 13:13
Base automatically changed from docker_and_experiments to main May 21, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants