-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: 세션 등록 시 출석 정보 등록 및 출석 정보 수정 기능 구현 #77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 컨트롤러, 서비스, 레파지토리 디렉토리, 파일 생성
- sessionDate, attendanceDeadLine Not Nullable - 출석 시간 JsonFormat 수정
- ADMIN만 접근 가능
Youthhing
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gikhoon 리뷰 남겼습니다! 확인 부탁드려요
src/main/java/org/cotato/csquiz/api/attendance/controller/AttendanceMemberController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/api/attendance/dto/UpdateAttendanceRequest.java
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/api/attendance/controller/AttendanceAdminController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/attendance/service/AttendanceAdminService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/attendance/service/AttendanceAdminService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/attendance/entity/Attendance.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/generation/service/SessionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/api/attendance/controller/AttendanceAdminController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/api/attendance/controller/AttendanceAdminController.java
Outdated
Show resolved
Hide resolved
@Youthhing 리뷰 완료했습니다 |
Youthhing
reviewed
Aug 1, 2024
Youthhing
reviewed
Aug 1, 2024
src/main/java/org/cotato/csquiz/api/attendance/controller/AttendanceAdminController.java
Show resolved
Hide resolved
- 기존 NotNull에서 Compact생성자로 디폴트 값 방식으로 변경
Youthhing
reviewed
Aug 1, 2024
src/main/java/org/cotato/csquiz/api/attendance/dto/AttendanceDeadLineDto.java
Show resolved
Hide resolved
Youthhing
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
이슈링크(url): #78
✅ 작업 내용
🗣 ️리뷰 요구 사항