-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Featured Items - Collection Page #575
Conversation
@ekraffmiller could you please reapprove? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved version update & typo fixes
Are we setting any limits on how many Content items we can have...On the Edit Featured Items page I added 101 content items, when I did, I had the observation below: Screen.Recording.2025-02-03.at.1.48.39.PM.movTo reproduce, just create a collection, edit> Featured Items, and add 100 Content items. The button class under the carousel seems to not function as expected. (not centered, tracker ball on button disappears after scrolling to beginning or end) |
Good question, I don't know about that, @GPortas what do you think? max 10 featured items for now? |
another observation when there are too many featured items: Screen.Recording.2025-02-03.at.2.09.08.PM.mov |
Thanks @ofahimIQSS, will take a look at this |
merging is blocked - can someone please review |
fixes look good overall, had one more UX improvement suggestion - can we limit the message to show one at a time until one message "You can add up to 10 featured items." goes away? See video below Screen.Recording.2025-02-04.at.11.48.26.AM.mov |
I think we could, we could limit how many alerts to show at the same time but I think it's not our problem if the user keeps clicking the add button and also it doesn't break anything. |
Agreed! lets keep it as is - please approve the review so I can merge this PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, approved
Thank you guys! This feature looks great - Merging PR |
What this PR does / why we need it:
Add featured items section in the Collection Page.
Allows users that can edit a collection to create "featured items" that will initially support content and an optional image.
These "featured items" will be shown between the Collection page header and the items list.
Storybook links:
Which issue(s) this PR closes:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm i && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the feature
<p class="rte-paragraph">Hello world</p>
so those html tags characters also count for the validation.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.
![Screen Shot 2025-01-02 at 08 49 32](https://private-user-images.githubusercontent.com/64560524/399693094-5b1862ae-fcf0-4aa1-afbf-205151f8ce1b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NTE1NjksIm5iZiI6MTczODg1MTI2OSwicGF0aCI6Ii82NDU2MDUyNC8zOTk2OTMwOTQtNWIxODYyYWUtZmNmMC00YWExLWFmYmYtMjA1MTUxZjhjZTFiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE0MTQyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRjZWNhN2U2OTVkYzFmZmU3YmVjNzVlZTI4NzljZTY2YTRlNTQ1OTYyYWY4MjRlMjMzOGIwMThiMTdmYmJkNjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.jYTYqAX1_WwyIBfntMICQAeVs8YuI4UnJz5ou1nuUZE)
![Screen Shot 2025-01-02 at 08 55 29](https://private-user-images.githubusercontent.com/64560524/399693317-6939a24a-8fa2-497e-bffa-244454874a98.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NTE1NjksIm5iZiI6MTczODg1MTI2OSwicGF0aCI6Ii82NDU2MDUyNC8zOTk2OTMzMTctNjkzOWEyNGEtOGZhMi00OTdlLWJmZmEtMjQ0NDU0ODc0YTk4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE0MTQyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA3YmJhZTBiMzQ1NjZhNDQzNDJjMjdiMTJjNjZmMWU1OTZjODllMTY0OWM5OWE4Yjg5YzhkZTYyZGMxYzU2NmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.OrGTVqUxYO6pTdq3HmmYA3LibdnLBqOVe__DoEWLNXc)
![Screen Shot 2025-01-02 at 08 55 40](https://private-user-images.githubusercontent.com/64560524/399693334-4a3ea5d5-78fb-4386-af96-219b827d2863.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NTE1NjksIm5iZiI6MTczODg1MTI2OSwicGF0aCI6Ii82NDU2MDUyNC8zOTk2OTMzMzQtNGEzZWE1ZDUtNzhmYi00Mzg2LWFmOTYtMjE5YjgyN2QyODYzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDE0MTQyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUyZTdhNDgxYWQwZGZlN2Y3OGFmNjcxNDM0YWEzM2RiNTA1YmNiZjI0ODdmMzU5MTU1OGM2NjdkMjBlNDVkMjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.K97AbpOPQf9vFU8TQ2GbTOlqo0ynEiU3-vAzImijPfE)
Is there a release notes update needed for this change?:
Additional documentation: