Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bridges between Uberon/CL and taxon-specific anatomy ontologies. #143

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gouttegd
Copy link
Collaborator

This PR adds the Uberon-provided bridges that link Uberon/CL and all the taxon-specific anatomy/development ontologies that are already included in Ubergraph.

The added bridges are for:

  • MA
  • WBbt/WBls
  • ZFA
  • MmusDv
  • HAO
  • EMAPA
  • FBdv

closes #136

This commit adds the Uberon-provided bridges that link Uberon/CL and all
the taxon-specific anatomy ontologies that are already included in
Ubergraph.

closes #136
@gouttegd gouttegd self-assigned this Jan 12, 2024
@gouttegd gouttegd requested a review from dosumis January 12, 2024 13:22
@balhoff
Copy link
Member

balhoff commented Jan 16, 2024

@gouttegd in my experience Uberon and EMAPA are not really compatible when logically bridged. Has this been fixed?

@gouttegd
Copy link
Collaborator Author

No. With Uberon’s disjointness axioms left in place, merging Uberon, EMAPA, and the Uberon-to-EMAPA bridge still yields ~1400 unsatisfiable classes.

@gouttegd
Copy link
Collaborator Author

gouttegd commented Mar 1, 2024

@dosumis @balhoff What is the intention here? Should those bridges be added only after the incompatibilities issues have been fixed?

@balhoff
Copy link
Member

balhoff commented Mar 1, 2024

Ubergraph is meant to be a logically coherent system, and the relation-graph depends on that. We could add "mapping" versions of the bridges that aren't compatible, such as UBERON:femur skos:closeMatch EMAPA:femur. @dosumis what is your opinion?

@dosumis
Copy link
Contributor

dosumis commented Mar 2, 2024

Agree we should keep it outside of the logic if it leads to so many inconsistencies. If we have a compelling use case for including EMAPA, maybe it should use SKOS for the bridge - at least until we have time to work on it. Grant gods willing, we may have funding next year.

@gouttegd
Copy link
Collaborator Author

gouttegd commented Mar 4, 2024

Note that EMAPA is not the only ontology to be currently incompatible with Uberon:

  • Uberon + EMAPA + Uberon-to-EMAPA bridge: 1519 unsats
  • Uberon + MA + Uberon-to-MA bridge: 512 unsats
  • Uberon + ZFA + Uberon-to-ZFA bridge: 196 unsats
  • Uberon + HAO + Uberon-to-HAO bridge: the entire ontology is inconsistent (owl:Thing inferred to be equivalent to owl:Nothing – this seems to be caused by a single bogus mapping, I’ll have a closer look later).

So do we only want the bridges that won’t cause inconsistencies?

@dosumis
Copy link
Contributor

dosumis commented Mar 14, 2024

So do we only want the bridges that won’t cause inconsistencies?

I think yes, but would like to work towards fixing for ontologies that are

(a) used in resources we have a compelling case to integrate or where a species specific ontology has clear value in annotation of single cell data (possibly not case for MA, as CL/Uberon are already widely used and should be sufficient
(b) the number of unsats suggests the work is manageable.

For now, I think that means ZFA. Also curious about whether we have a mapping from XAO. Potentially useful for community annotating Xenopus scRNAseq data.

I'm happy to have xref mappings for the others - using mappings in Uberon. That could be useful for EMAPA as we may want mappings to this for work at Sanger - it's possible we will have resources for this at some point in the near future if non-trivial.

@gouttegd
Copy link
Collaborator Author

(b) the number of unsats suggests the work is manageable.

For now, I think that means ZFA

Of note, many of unsatisfiability issues with ZFA were spotted a long time ago and seemingly never addressed on either side.

It doesn’t necessarily mean those issues are not manageable, but I’d be wary of using the (relatively low) number of unsats as an indicator of how easy it would be to fix them.

Several of them seem to be the consequence of a fundamental incompatibility between Uberon and ZFA, where what ZFA calls a “head“ corresponds to the head and the neck in Uberon (incompatibility first flagged here, 10 years ago).

Also curious about whether we have a mapping from XAO.

We have ~600 mappings between Uberon and XAO. Using them to bridge the two ontologies yields 208 unsats.

@gouttegd
Copy link
Collaborator Author

gouttegd commented Jul 2, 2024

Converting to draft as it is going to take a while to fix the unsats between Uberon and the taxon-specific ontologies.

@gouttegd gouttegd marked this pull request as draft July 2, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bridges from Uberon/CL to Taxon-specific ontologies
3 participants