Fixed issues #1, #3 added some new features. #7
Conversation
Added 'unknown' handler to reply to unknown commands. Fixed error in 'empty_message' handle dispatcher. Fixed errors to handle exception in 'welcome' and 'empty_message'. Removed unneceesary comments and added meaningful ones in 'welcome' making code more concise(see issue ILUGD#1).
| @@ -82,17 +82,25 @@ def help(bot, update): | |||
| /github - link to ilugd github repos | |||
| ''') | |||
|
|
|||
| def unknown(bot, update): | |||
ilugd.py
Outdated
| except KeyError: | ||
| member_first_name = message.new_chat_members[0]['first_name'] | ||
|
|
||
| phrases = ['Hello {}! Welcome to {} .Please introduce yourself. Dont forget to read the chat rules using !rules command'.format(member_first_name,message.chat.title)] |
There was a problem hiding this comment.
why modify the list it was planned to expand it so that if multiple people join on same day its too boring to receive same message
There was a problem hiding this comment.
There was no documentation or comment about it. I will write a comment and add a few more welcoming messages. Should I proceed?
There was a problem hiding this comment.
applies to same sticker what do you think (i was thinking like a list and throw a random one to chat)
There was a problem hiding this comment.
There was no documentation or comment about it. I will write a comment and add a few more welcoming messages. Should I proceed?
yupz (also for stickers (I love gifs))
There was a problem hiding this comment.
It sounds awesome! Also what about the '!rules' command mentioned in 'phrases'? How should I go about it?
There was a problem hiding this comment.
So, for the time being, I will make changes for stickers and 'phrases' and will raise an issue about the 'rules' command to be solved in future commits. Is that all right?
sachinkumarsingh092
force-pushed
the
new-features
branch
from
8aef2c7 to
6841fb6
Compare
|
I messed up a bit. Please find the latest changes to be merged. Sorry about that. |
Added a sticker to welcome new users(see issue #3).
Added 'unknown' handler to reply to unknown commands.
Fixed error in 'empty_message' handle dispatcher.
Fixed errors to handle exception in 'welcome' and 'empty_message'.
Removed unnecessary comments and added meaningful ones in 'welcome' making code more concise(see issue #1).