Feat/check subprocess return code #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
Hi ! |
|
I was waiting the checks before updating the PR 😄 The goal is to avoid launching a step if an error occurs in a previous step. |
|
That's a very cool feature ! Thanks ! ;) |
jmkerloch
force-pushed
the
feat/check_subprocess_return_code
branch
from
0d29864
to
dfdd07b
Compare
lgrd
approved these changes
Mar 21, 2024
azarz
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we check return code for all subprocess in route-graph-generator.
If the return code is different than 0 it mean that an error occured in the process.
In this case we should not continue and we raise a RuntimeError.