Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{id} in history storage filename #1118

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Conversation

plakrisenko
Copy link
Member

At the moment, if MultiProcessEngine is used and HistoryOptions storage_file contains "{id}" it lead to an error.

It's a minor thing, but is inconvenient when switching between SingleCoreEngine and MultiProcessEngine

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Merging #1118 (629732c) into develop (160c2a8) will decrease coverage by 3.78%.
Report is 385 commits behind head on develop.
The diff coverage is 87.95%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #1118      +/-   ##
===========================================
- Coverage    88.16%   84.39%   -3.78%     
===========================================
  Files           79      148      +69     
  Lines         5257    11642    +6385     
===========================================
+ Hits          4635     9825    +5190     
- Misses         622     1817    +1195     
Files Coverage Δ
pypesto/C.py 100.00% <100.00%> (ø)
pypesto/__init__.py 100.00% <100.00%> (ø)
pypesto/engine/__init__.py 100.00% <100.00%> (ø)
pypesto/engine/multi_process.py 93.10% <100.00%> (+0.79%) ⬆️
pypesto/engine/multi_thread.py 100.00% <100.00%> (ø)
pypesto/engine/single_core.py 100.00% <100.00%> (ø)
pypesto/engine/task.py 100.00% <100.00%> (ø)
pypesto/ensemble/__init__.py 100.00% <100.00%> (ø)
pypesto/ensemble/task.py 100.00% <100.00%> (ø)
pypesto/hierarchical/__init__.py 100.00% <100.00%> (ø)
... and 138 more

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@plakrisenko plakrisenko merged commit 33da118 into develop Oct 10, 2023
18 checks passed
@PaulJonasJost PaulJonasJost mentioned this pull request Oct 11, 2023
@PaulJonasJost PaulJonasJost deleted the id_in_history_storage_filename branch October 24, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants