fix expiration date for locally signed certs #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Realized that the expiration date was being set to 1 year out instead of what was specified by new_expiry_date when signed by local CA. GENCERT command needed the expiration date as well. Also removed handlers for setropts refresh so that it could be done before a listing of the renewed certificate at the end to verify visually in the output that renewal was successful. Signed-off-by: Jacob Emery <[email protected]>
|
@ddimatos please take a look when you get a chance, very small change to the cert renewal playbook to fix expiration date not being set correctly. |
itsBryantP
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized that the expiration date was being set to 1 year out instead of what was specified by new_expiry_date when signed by local CA. The GENCERT command needed the expiration date as well, or else it would default to 1 year out.
Also removed handlers for setropts refresh so that it could be done before a listing of the renewed certificate at the end to verify visually in the output that renewal was successful.