Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated registrykey dependencies #1262

Merged
merged 8 commits into from
Jan 3, 2025
Merged

Remove deprecated registrykey dependencies #1262

merged 8 commits into from
Jan 3, 2025

Conversation

badri-pathak
Copy link
Member

@badri-pathak badri-pathak commented Dec 18, 2024 •
edited
Loading

Pull request checklist

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature Enhancement
  • Test Automation
  • Code Refactoring (no functional changes, no api changes)
  • Build related changes
  • Community Operator listing
  • Other (please describe):

What is the current behavior?

What is the new behavior?

How risky is this change?

  • Small, isolated change
  • Medium, requires regression testing
  • Large, requires functional and regression testing

@badri-pathak badri-pathak changed the title Remove deprecated registrykey dependencies Don't Merge : Remove deprecated registrykey dependencies Dec 18, 2024
@badri-pathak badri-pathak marked this pull request as draft December 18, 2024 13:33
@badri-pathak
Copy link
Member Author

Issue needs to handle https://github.ibm.com/IBMSpectrumScale/scale-core/issues/8074

@badri-pathak badri-pathak marked this pull request as ready for review December 19, 2024 11:45
@badri-pathak badri-pathak changed the title Don't Merge : Remove deprecated registrykey dependencies Remove deprecated registrykey dependencies Dec 19, 2024
@badri-pathak
Copy link
Member Author

PR to handle above issue is #1263

@badri-pathak
Copy link
Member Author

Image: quay.io/badri_pathak/ibm-spectrum-scale-csi-operator:testSAUpgrade213_v1

saurabhwani5
saurabhwani5 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@saurabhwani5 saurabhwani5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working as expected

@Jainbrt Jainbrt merged commit ae8fb79 into IBM:release-2.13 Jan 3, 2025
2 checks passed
@badri-pathak badri-pathak deleted the remove_deprecatedkey213 branch January 8, 2025 13:50
@badri-pathak badri-pathak added this to the v2.14.0 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabhwani5 saurabhwani5 saurabhwani5 approved these changes

@Jainbrt Jainbrt Jainbrt approved these changes

@hemalathagajendran hemalathagajendran Awaiting requested review from hemalathagajendran

@deeghuge deeghuge Awaiting requested review from deeghuge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@badri-pathak @Jainbrt @saurabhwani5