review findings

Signed-off-by: Rainer Schoenberger <[email protected]>
IBM · Feb 26, 2024 · 6b7b96b · 6b7b96b
1 parent d53eeb2
commit 6b7b96b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/libCli/MessageFormatterJson.cpp b/src/libCli/MessageFormatterJson.cpp
@@ -28,7 +28,7 @@ namespace cli
         // Will print primitive fields regardless of their values. So e.g. an int32 field set to 0 will not be omitted. 
         printOptions.always_print_primitive_fields = true;
 
-        auto status = google::protobuf::util::MessageToJsonString(f_message, &resultString, printOptions);
+        const auto status = google::protobuf::util::MessageToJsonString(f_message, &resultString, printOptions);
         if(not status.ok())
         {
             resultString = std::string("Json encoding of Message failed: ") + status.ToString();

diff --git a/src/libCli/MessageParserJson.cpp b/src/libCli/MessageParserJson.cpp
@@ -54,9 +54,8 @@ std::vector<std::unique_ptr<google::protobuf::Message>> MessageParserJson::parse
             }
             std::stringstream buffer;
             buffer << source->rdbuf();
-            std::string fileContent = buffer.str();
             auto status = google::protobuf::util::JsonStringToMessage(
-                    fileContent,
+                    buffer.str(),
                     message.get(),
                     google::protobuf::util::JsonParseOptions());
             if(not status.ok())