fix: update async iterator to parse incoming message (#171)

Co-authored-by: fern-api <115122769+fern-api[bot]@users.noreply.github.com> Co-authored-by: Norman Bukingolts <[email protected]>
HumeAI · Sep 11, 2024 · a81f2c0 · a81f2c0
1 parent fb423bc
commit a81f2c0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 14 deletions.
diff --git a/.github/workflows/legacy_ci.yml b/.github/workflows/legacy_ci.yml
@@ -21,10 +21,10 @@ jobs:
           - "3.11"
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Python ${{ matrix.python-version }} Setup
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ matrix.python-version }}
 
@@ -38,7 +38,6 @@ jobs:
         shell: bash
         run: |
           pip install poetry
-
           if [ -d /poetryenvs ]; then rm -rf ~/poetryenvs; fi
           poetry config virtualenvs.path ~/poetryenvs
           poetry install
@@ -66,13 +65,13 @@ jobs:
           poetry run pydocstyle hume
 
       - name: Upload HTML Coverage
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: hume-unit-coverage-html
           path: hume/htmlcov
 
       - name: Upload XML Coverage
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: hume-unit-coverage-xml
           path: hume/coverage.xml
@@ -88,10 +87,10 @@ jobs:
           - "3.10"
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Python ${{ matrix.python-version }} Setup
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ matrix.python-version }}
 
@@ -105,7 +104,6 @@ jobs:
         shell: bash
         run: |
           pip install poetry
-
           if [ -d /poetryenvs ]; then rm -rf ~/poetryenvs; fi
           poetry config virtualenvs.path ~/poetryenvs
           poetry install
@@ -119,13 +117,13 @@ jobs:
           poetry run pytest tests/custom/_legacy -m service
 
       - name: Upload HTML Coverage
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: hume-service-coverage-html
           path: hume/htmlcov
 
       - name: Upload XML Coverage
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: hume-service-coverage-xml
           path: hume/coverage.xml
@@ -139,10 +137,10 @@ jobs:
           - "3.10"
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Python ${{ matrix.python-version }} Setup
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ matrix.python-version }}
 

diff --git a/src/hume/empathic_voice/chat/socket_client.py b/src/hume/empathic_voice/chat/socket_client.py
@@ -61,7 +61,7 @@ def __init__(
 
     async def __aiter__(self):
         async for message in self.websocket:
-            yield message
+            yield parse_obj_as(SubscribeEvent, json.loads(message))  # type: ignore
 
     async def _send(self, data: typing.Any) -> None:
         if isinstance(data, dict):

diff --git a/src/hume/expression_measurement/stream/socket_client.py b/src/hume/expression_measurement/stream/socket_client.py
@@ -38,7 +38,7 @@ def __init__(
 
     async def __aiter__(self):
         async for message in self.websocket:
-            yield message
+            yield parse_obj_as(SubscribeEvent, json.loads(message))  # type: ignore
 
     # TODO: we can likely coerce the right response model within the union here, if we're
     # assuming request-response pattern and 1:1 mapping between request and response types