feat: LEAP-1515: Hide PII by condition #6544
Open
+58
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With new LSF interface `annotations:hide-info` hide all personal info about users and annotation, including ids and dates.
…_reviewer_firewall_enabled` is true
It should be visually connected with labeling area
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Gondragos
reviewed
Oct 23, 2024
| @@ -55,6 +55,8 @@ const DraftState: FC<{ | |||
| }> = observer(({ annotation, inline, isSelected }) => { | |||
| const hasChanges = annotation.history.hasChanges; | |||
| const store = annotation.list; // @todo weird name | |||
| const infoIsHidden = store.store.hasInterface("annotations:hide-info"); | |||
| const hiddenUser = infoIsHidden ? { email: "Me" } : null; | |||
There was a problem hiding this comment.
Is it possible that the user who will be replaced by "Me" is not actually the current one?
There was a problem hiding this comment.
Nwm. Looks like with annotations:hide-info we are going to prevent such cases from appearing.
Gondragos
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reduce a bias organization can now enable org setting
annotator_reviewer_firewall_enabledto hide all related identifying information in annotations:Technically it's done by passing new LSF interface
annotations:hide-infoand changing UI by condition.Label Stream
Quick View with other users involved
It is advised to hide Data Manager for projects in such organizations.
PR fulfills these requirements
Change has impacts in these area(s)
What alternative approaches were there?
Hide this data on backend — frontend solution is easier and good for now.
Also we could add styles just to hide some elements, but that would not allow us to replace text and would be harder to maintain.
Also we could dynamically change the data via Custom Scripts, but that's uncontrollable and unstable because of dynamic nature of this data.
What feature flags were used to cover this change?
No FFs, the feature is hidden behind org setting
annotator_reviewer_firewall_enabled.Does this PR introduce a breaking change?