Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LEAP-1533: Make Quick View readonly by condition #6539

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Oct 18, 2024

When org field read_only_quick_view_enabled is true, then we have to make Quick View readonly. We have editable field in Annotation, but every annotation select makes it editable again. So we will override this on every select by condition.

PR fulfills these requirements

  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

What alternative approaches were there?

We could use readonly field, but it doesn't affect buttons for example.

What feature flags were used to cover this change?

No FF, just an org field read_only_quick_view_enabled.

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

@github-actions github-actions bot added the feat label Oct 18, 2024
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 5f907f7
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67184403dcd5340008edb71f
😎 Deploy Preview https://deploy-preview-6539--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 5f907f7
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/671844037076030008d4f19b
😎 Deploy Preview https://deploy-preview-6539--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Org field `read_only_quick_view_enabled`
@hlomzik
Copy link
Collaborator Author

hlomzik commented Oct 23, 2024

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/editor/tests/integration/e2e/relations/audio.cy.ts

@robot-ci-heartex
Copy link
Collaborator

Follow Merge downstream workflow has been failed.

Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants