-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LEAP-1490: Fix AudioUltra working with relations and comments #6494
Conversation
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
web/libs/editor/src/regions/AudioRegion/AudioUltraRegionModel.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 😎, just a suggestion on the snake_case -> camelCase, but logically speaking that won't affect this getting tested. Accidentally approved prematurely, taking this back to when the PR is considered for review officially.
/git merge develop
|
Follow Merge downstream workflow has been failed. |
/git merge develop
|
Co-authored-by: bmartel <[email protected]>
Fix some tests helpers problems
web/libs/editor/tests/integration/e2e/audio/audio_regions.cy.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work 🔥
Co-authored-by: bmartel <[email protected]>
/git merge develop
|
Follow Merge downstream workflow has been failed. |
2 similar comments
Follow Merge downstream workflow has been failed. |
Follow Merge downstream workflow has been failed. |
This PR fixes the way AudioUltra works with Relations and linking comments (it didn't work and that was a regression), and some small bugs related to AudioUltra itself.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
What feature flags were used to cover this change?
N/A
Does this PR introduce a breaking change?
(check only one)
It shouldn't be like that if I don't break something.
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Audio
,AudioUltra
,Relations
,LinkingModes
,Comments