You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"annotation:bulk" interface that allows to hide all panels and elements that can't be set equally to group of annotaions
ability to customize control buttons and an interface "controls:custom" indicating that we are going to take control on rendere of these buttons
fix the way we deliver config in cypress tests
PR fulfills these requirements
Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Tests for the changes have been added/updated (for bug fixes/features)
Docs have been added/updated (for bug fixes/features)
Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
Self-reviewed and ran all changes on a local instance (for bug fixes/features)
Change has impacts in these area(s)
Product design
Backend (Database)
Backend (API)
Frontend
What feature flags were used to cover this change?
- for bulk annotation mode displaying
- for custom controls rendering and modify on fly
- fix delivering the config from the cypress environment into the test environment
Would not it be better to name interface "annotation:bulk"? That will keep it in a shape of namespace:detail like for lot of other interfaces. I know they are a mess but that's a really lowcost change on an early stage with small benefit
Separated bulk mode and independence checks into variables for readability. This makes the conditional logic clearer and potentially reduces redundancy in code review and debugging processes. No functional changes have been introduced.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
"annotation:bulk"interface that allows to hide all panels and elements that can't be set equally to group of annotaions"controls:custom"indicating that we are going to take control on rendere of these buttonsPR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
What feature flags were used to cover this change?
fflag_feat_all_leap_1181_bulk_annotation_shortDoes this PR introduce a breaking change?
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Editor,BottomBar