-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: OPTIC-719: TypeError: e.target.className.includes is not a funct…
…ion (#5847) Error coming from Sentry https://heartex.sentry.io/issues/5039994894/ There is no impact on the user. This happens when a user drags and drops, for example, when the column header is an SVG. I confirm that the drag-and-drop feature continues to work well. Also, `?` wont work because in the case of failure is an image that is an svg and className is a `SVGAnimatedString` object. No need to pursue baseVal since we don't have the className `handle` --------- Co-authored-by: Raul Martin <[email protected]> Co-authored-by: hlomzik <[email protected]> Co-authored-by: robot-ci-heartex <[email protected]>
- Loading branch information
1 parent
c7b4b98
commit 8efbfac
Showing
7 changed files
with
26 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "fix: LEAP-1049: support loading TimeSeries URL from sub-property of data (#5610)", | ||
"commit": "d8819c35df0430a6adf646faa99b73e6f5df3f4f", | ||
"date": "2024-05-14T19:41:41.000Z", | ||
"branch": "fb-LEAP-1049/harrymander-fix-for-timeseries-urls" | ||
"message": "add comment", | ||
"commit": "d14113cce25e4bd294a7c4a8c57917ab06a923e0", | ||
"date": "2024-05-08T15:50:58.000Z", | ||
"branch": "fb-optic-719/typeerror" | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "fix: LEAP-1049: support loading TimeSeries URL from sub-property of data (#5610)", | ||
"commit": "d8819c35df0430a6adf646faa99b73e6f5df3f4f", | ||
"date": "2024-05-14T19:41:41.000Z", | ||
"branch": "fb-LEAP-1049/harrymander-fix-for-timeseries-urls" | ||
"message": "add comment", | ||
"commit": "d14113cce25e4bd294a7c4a8c57917ab06a923e0", | ||
"date": "2024-05-08T15:50:58.000Z", | ||
"branch": "fb-optic-719/typeerror" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "fix: LEAP-1049: support loading TimeSeries URL from sub-property of data (#5610)", | ||
"commit": "d8819c35df0430a6adf646faa99b73e6f5df3f4f", | ||
"date": "2024-05-14T19:41:41.000Z", | ||
"branch": "fb-LEAP-1049/harrymander-fix-for-timeseries-urls" | ||
"message": "add comment", | ||
"commit": "d14113cce25e4bd294a7c4a8c57917ab06a923e0", | ||
"date": "2024-05-08T15:50:58.000Z", | ||
"branch": "fb-optic-719/typeerror" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters