Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Project ID in create method #390

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ddishi
Copy link

@ddishi ddishi commented Jan 22, 2025

Add project ID to ProjectsCreateResponse object in ProjectsClient class.

  • Add id field of type int to ProjectsCreateResponse class in src/label_studio_sdk/projects/types/projects_create_response.py
  • Update create method in ProjectsClient class in src/label_studio_sdk/projects/client.py to include id field in ProjectsCreateResponse object and populate it from the response JSON
  • Update test_create function in tests/test_projects.py to include id field in the expected response and validate it

For more details, open the Copilot Workspace session.

Add project ID to `ProjectsCreateResponse` object in `ProjectsClient` class.

* Add `id` field of type `int` to `ProjectsCreateResponse` class in `src/label_studio_sdk/projects/types/projects_create_response.py`
* Update `create` method in `ProjectsClient` class in `src/label_studio_sdk/projects/client.py` to include `id` field in `ProjectsCreateResponse` object and populate it from the response JSON
* Update `test_create` function in `tests/test_projects.py` to include `id` field in the expected response and validate it

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/HumanSignal/label-studio-sdk?shareId=XXXX-XXXX-XXXX-XXXX).
@ddishi ddishi changed the title Fix project ID in create method fix: Project ID in create method Jan 22, 2025
@niklub
Copy link
Contributor

niklub commented Jan 24, 2025

Thanks for pointing out this issue. The SDK functionality is autogenerated and will be updated on the next run. The proper way of handling the fix is here HumanSignal/label-studio-client-generator#51

@benglewis
Copy link

@niklub Is there an estimate of how long it will take until this is released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants